LGTM
http://codereview.chromium.org/6880010/diff/3077/src/heap-inl.h File src/heap-inl.h (right): http://codereview.chromium.org/6880010/diff/3077/src/heap-inl.h#newcode478 src/heap-inl.h:478: 2 blank lines http://codereview.chromium.org/6880010/diff/3077/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/heap.cc#newcode85 src/heap.cc:85: reserved_semispace_size_(8*MB), We have until now limited max semispace size to 4mb on the gc branch. this costs us performance but helps pause time. if we want to experiment with this lets do it as a separate change. http://codereview.chromium.org/6880010/diff/3077/src/heap.h File src/heap.h (right): http://codereview.chromium.org/6880010/diff/3077/src/heap.h#newcode272 src/heap.h:272: // All JavaScript contexts by this process share the same object heap. This comment is out of date, but thats a bug on bleeding edge http://codereview.chromium.org/6880010/diff/3077/src/mark-compact-inl.h File src/mark-compact-inl.h (right): http://codereview.chromium.org/6880010/diff/3077/src/mark-compact-inl.h#newcode56 src/mark-compact-inl.h:56: // TODO(gc) !!!!!! Marking has a heap_ field so this is easy to fix. http://codereview.chromium.org/6880010/diff/3077/src/serialize.cc File src/serialize.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/serialize.cc#newcode516 src/serialize.cc:516: 41, oooops http://codereview.chromium.org/6880010/diff/3077/src/spaces-inl.h File src/spaces-inl.h (right): http://codereview.chromium.org/6880010/diff/3077/src/spaces-inl.h#newcode280 src/spaces-inl.h:280: return object->map() == HEAP->raw_unchecked_free_space_map() I think this needs a todo http://codereview.chromium.org/6880010/diff/3077/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/spaces.cc#newcode1375 src/spaces.cc:1375: set_map(HEAP->raw_unchecked_free_space_map()); Needs a todo http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.cc#newcode318 src/store-buffer.cc:318: Address* top = reinterpret_cast<Address*>(HEAP->store_buffer_top()); Use heap_ here and below http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.h File src/store-buffer.h (right): http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.h#newcode43 src/store-buffer.h:43: // TODO(gc) ISOLATESMERGE convert to non static class Is this not done? http://codereview.chromium.org/6880010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
