LGTM with comments
http://codereview.chromium.org/6904127/diff/1/src/log.cc File src/log.cc (right): http://codereview.chromium.org/6904127/diff/1/src/log.cc#newcode1098 src/log.cc:1098: HashMap::Entry* entry = address_to_name_map_->Lookup( This code is repeated several times. Worth extracting into a function? Or even better -- wrap the hashmap into a class. http://codereview.chromium.org/6904127/diff/1/src/utils.h File src/utils.h (right): http://codereview.chromium.org/6904127/diff/1/src/utils.h#newcode254 src/utils.h:254: static inline uint32_t ComputePointerHash(void* ptr) { As we intend to deal with Addresses, maybe it's a good idea to use an Address type here? http://codereview.chromium.org/6904127/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
