Thanks for quick review!
http://codereview.chromium.org/6904127/diff/1/src/log.cc File src/log.cc (right): http://codereview.chromium.org/6904127/diff/1/src/log.cc#newcode1098 src/log.cc:1098: HashMap::Entry* entry = address_to_name_map_->Lookup( On 2011/04/29 14:20:28, Mikhail Naganov (Chromium) wrote:
This code is repeated several times. Worth extracting into a function?
Or even
better -- wrap the hashmap into a class.
Created a class. It's +20 lines overall, but the code is hopefully more readable. http://codereview.chromium.org/6904127/diff/1/src/utils.h File src/utils.h (right): http://codereview.chromium.org/6904127/diff/1/src/utils.h#newcode254 src/utils.h:254: static inline uint32_t ComputePointerHash(void* ptr) { On 2011/04/29 14:20:28, Mikhail Naganov (Chromium) wrote:
As we intend to deal with Addresses, maybe it's a good idea to use an
Address
type here?
Don't think so --- it'll require casting from everything that is not byte*. http://codereview.chromium.org/6904127/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
