I'll take care of the rest on Monday.
http://codereview.chromium.org/7014019/diff/8001/src/extensions/experimental/datetime-format.h File src/extensions/experimental/datetime-format.h (right): http://codereview.chromium.org/7014019/diff/8001/src/extensions/experimental/datetime-format.h#newcode37 src/extensions/experimental/datetime-format.h:37: } I need this for forward declaration of icu::SimpleDateFormat. You need to say: namespace X { class Y; } You can't say: class X::Y; On 2011/05/13 23:37:53, Jungshik Shin wrote:
U_USING_ICU_NAMESPACE is set to 0 for all the projects that rely on
ICU in the
latest version of icu.gyp. So, I guess you don't need this any more.
http://codereview.chromium.org/7014019/diff/8001/src/extensions/experimental/datetime-format.h#newcode60 src/extensions/experimental/datetime-format.h:60: // Get list of months - narrow or wide format. We decided (last meeting) to use only standalone symbols, to avoid problems like people concatenating symbols to get "proper" dates. On 2011/05/13 23:37:53, Jungshik Shin wrote:
how about formatting vs stand-alone? For use in menus, stand-alone
names (as
opposed to "formatting" names) are needed. We need to review the spec
and add
this distinction if that's not yet covered.
http://codereview.chromium.org/7014019/diff/8001/src/extensions/experimental/i18n-utils.h File src/extensions/experimental/i18n-utils.h (right): http://codereview.chromium.org/7014019/diff/8001/src/extensions/experimental/i18n-utils.h#newcode38 src/extensions/experimental/i18n-utils.h:38: } Same as for datetime-format.h. Forward declaration of class from icu namespace. On 2011/05/13 23:37:53, Jungshik Shin wrote:
this is not necessary any more with the latest icu.gyp in the chrome
tree. http://codereview.chromium.org/7014019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
