Bindings part LGTM
http://codereview.chromium.org/7014019/diff/10001/src/extensions/experimental/datetime-format.cc File src/extensions/experimental/datetime-format.cc (right): http://codereview.chromium.org/7014019/diff/10001/src/extensions/experimental/datetime-format.cc#newcode84 src/extensions/experimental/datetime-format.cc:84: return v8::ThrowException(v8::Exception::Error( In case of an exception here, do you want to catch it and throw something else or do you want to just rethrow the exception from 'new Date()'? I think I would lean towards using try_catch.ReThrow() here, but I'll leave that to your judgement. http://codereview.chromium.org/7014019/diff/10001/src/extensions/experimental/datetime-format.cc#newcode177 src/extensions/experimental/datetime-format.cc:177: CHECK_EQ(2, args.Length()); Ah, so this can only ever be called with two strings? These should be ASSERT_EQ and ASSERT. Thanks for adding the assertions! http://codereview.chromium.org/7014019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
