http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right):
http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc#newcode2592 src/x64/macro-assembler-x64.cc:2592: j(above, &above_zero, Label::kNear); I believe NaN should also be converted to zero (i.e., if the P flag is set after ucomisd) http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc#newcode2606 src/x64/macro-assembler-x64.cc:2606: roundsd(temp_xmm_reg, input_reg, kRoundToNearest); I tried to look up a spec for typed arrays, and if the one I found was correct, we should just round towards zero, i.e., truncate. http://codereview.chromium.org/7014033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
