http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right):
http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc#newcode2592 src/x64/macro-assembler-x64.cc:2592: j(above, &above_zero, Label::kNear); Ack, yes. I didn't consider that "above" would also match NaN (which is great :). http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc#newcode2606 src/x64/macro-assembler-x64.cc:2606: roundsd(temp_xmm_reg, input_reg, kRoundToNearest); I read that as clamping positions to the edge of the available image when a filtering algorithm needs surrounding pixels that aren't in the image. I don't see anything about rounding double values to octets for the pixel array (but I can see that Firefox is using round-to-even on my machine, so they are probably using roundsd). http://codereview.chromium.org/7014033/diff/4001/src/x64/macro-assembler-x64.cc#newcode2611 src/x64/macro-assembler-x64.cc:2611: addsd(temp_xmm_reg, input_reg); Good :) http://codereview.chromium.org/7014033/diff/4001/test/mjsunit/external-array.js File test/mjsunit/external-array.js (right): http://codereview.chromium.org/7014033/diff/4001/test/mjsunit/external-array.js#newcode155 test/mjsunit/external-array.js:155: That's fine. If you have a test that is known to fail for now, you can add a test file in mjsunit/bugs. It'll default to expecting to fail, and can be moved to mjsunit/regress when the bug is fixed. http://codereview.chromium.org/7014033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
