http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc#newcode743 src/arm/full-codegen-arm.cc:743: ASSERT(mode != Variable::CONST); This needs a comment that a const declaration of a parameter would be a redeclaration, and we'd never get here. http://codereview.chromium.org/6966033/diff/1/src/arm/full-codegen-arm.cc#newcode744 src/arm/full-codegen-arm.cc:744: ASSERT(function != NULL); I think this is wrong: function f(x) { var x = arguments[0]; } Has a declaration of x, rewritten to a property, and not a function. I think you'll need to keep if (function != NULL) { ... } And just emit no code in the function == NULL cases. http://codereview.chromium.org/6966033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
