I think you forgot to upload the updated x64 version.
LGTM with the analogous x64 change. http://codereview.chromium.org/6966033/diff/3001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6966033/diff/3001/src/arm/full-codegen-arm.cc#newcode749 src/arm/full-codegen-arm.cc:749: // A const declaration aliasing a parameter is a illegal redeclaration. "a" ==> "an" :) http://codereview.chromium.org/6966033/diff/3001/src/arm/full-codegen-arm.cc#newcode752 src/arm/full-codegen-arm.cc:752: // Store the function for a function declaration. This whole function is doing nothing for a regular var declaration and storing the function for a function declaration (also initializing to the hole for constants). I don't really think a special comment is needed here. http://codereview.chromium.org/6966033/diff/3001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/6966033/diff/3001/src/x64/full-codegen-x64.cc#newcode718 src/x64/full-codegen-x64.cc:718: ASSERT(function != NULL); You still can't assert this here. http://codereview.chromium.org/6966033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
