This change contains a lot of reformatting - automatically done by Eclipse I
suppose. Some of it does not adhere to the style guide, and the rest
clutters
the change.
Please revert the reformatting so the real change stands out.
If you think some of the style changes are needed please do that as a
separate
change.
http://codereview.chromium.org/7134040/diff/1/src/d8.cc
File src/d8.cc (left):
http://codereview.chromium.org/7134040/diff/1/src/d8.cc#oldcode161
src/d8.cc:161:
We always try to keep two blank lines between functions.
http://codereview.chromium.org/7134040/diff/1/src/d8.h
File src/d8.h (right):
http://codereview.chromium.org/7134040/diff/1/src/d8.h#newcode41
src/d8.h:41: public:
One space indent for public/private/protected (several times below), see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Class_Format#Class_Format.
http://codereview.chromium.org/7134040/diff/1/src/d8.h#newcode44
src/d8.h:44: int32_t* ptr() {
Why did you re-format all these accessors?
http://codereview.chromium.org/7134040/diff/1/src/d8.h#newcode82
src/d8.h:82: CounterMap() :
If you want to format this on several lines the ':' needs to be on the
next line with a four space indent. See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constructor_Initializer_Lists#Constructor_Initializer_Lists
http://codereview.chromium.org/7134040/diff/1/src/d8.h#newcode128
src/d8.h:128: static bool ExecuteString(Handle<String> source,
Handle<Value> name,
I think you should keep the original formatting of the function
arguments, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Calls#Function_Calls.
http://codereview.chromium.org/7134040/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
