I included your suggestions. Including those JS arguments into
CreateGlobalTemplate leads to crashes so I didn't do this. So is this good
for
commit?
http://codereview.chromium.org/7134040/diff/1003/src/d8.cc
File src/d8.cc (left):
http://codereview.chromium.org/7134040/diff/1003/src/d8.cc#oldcode619
src/d8.cc:619: // Mark the d8 shell script as native to avoid it showing
up as normal source
On 2011/06/09 12:36:04, Søren Gjesse wrote:
Is this last part of the installation of the utility script not
missing in the
refactored version?
Indeed. Must have gotten lost when I moved the code around.
http://codereview.chromium.org/7134040/diff/1003/src/d8.cc
File src/d8.cc (right):
http://codereview.chromium.org/7134040/diff/1003/src/d8.cc#newcode596
src/d8.cc:596:
On 2011/06/09 12:36:04, Søren Gjesse wrote:
Can the adding of the "os" object be part of the CreateGlobalTemplate?
yes
http://codereview.chromium.org/7134040/diff/1003/src/d8.cc#newcode604
src/d8.cc:604:
On 2011/06/09 12:36:04, Søren Gjesse wrote:
Also can adding the arguments be part of CreateGlobalTemplate? I know
that they
would then also be available in the utility context, but that will
probably be
ok.
I tried that. this would lead to crashes somehow.
http://codereview.chromium.org/7134040/diff/1003/src/d8.h
File src/d8.h (right):
http://codereview.chromium.org/7134040/diff/1003/src/d8.h#newcode132
src/d8.h:132: static void Initialize();
On 2011/06/09 12:36:04, Søren Gjesse wrote:
Please rename to RenewEvaluationContext as using the name "eval" might
cause
confusion with the JavaScript eval function.
Done.
http://codereview.chromium.org/7134040/diff/1003/src/d8.h#newcode133
src/d8.h:133: static void RenewEvalContext();
On 2011/06/09 12:36:04, Søren Gjesse wrote:
Rename Util ->Utility
Done.
http://codereview.chromium.org/7134040/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
