LGTM as a first step.
http://codereview.chromium.org/7046073/diff/1/src/full-codegen.cc File src/full-codegen.cc (right): http://codereview.chromium.org/7046073/diff/1/src/full-codegen.cc#newcode747 src/full-codegen.cc:747: DoTest(expr, &discard, &restore, &restore); Shouldn't the test of the left subexpressions get the test ID left->test_id()? It has to match what the Crankshaft graph builder is doing. http://codereview.chromium.org/7046073/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7046073/diff/1/src/hydrogen.cc#newcode1991 src/hydrogen.cc:1991: test_context_ = new TestContext(owner, cond, if_true, if_false); On 2011/06/09 10:07:57, Sven wrote:
Is this part of the change correct? I'm only 50% sure... :-/
You probably want the call-instruction as the condition here. Inlined functions may be a little tricky, since each return-statement will become a HTest. I guess it is fine to use the type feedback (and test_id) of the call-instruction. Not sure if specializing each return-site would help much. http://codereview.chromium.org/7046073/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
