http://codereview.chromium.org/7046073/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/7046073/diff/1/src/arm/full-codegen-arm.cc#newcode386 src/arm/full-codegen-arm.cc:386: codegen()->DoTest(condition_, true_label_, false_label_, fall_through_); On 2011/06/10 09:35:06, Kevin Millikin wrote:
Hmmm, it might be useful to have a DoTest that takes a test context
(and just
forwards to the one with explicit arguments) for simplicity.
I think it even makes sense to have *only* such a DoTest. This has the advantage that the fact will be very explicit that we use the value of the left operand for *2* things: The value itself and for control. http://codereview.chromium.org/7046073/diff/1/src/full-codegen.cc File src/full-codegen.cc (right): http://codereview.chromium.org/7046073/diff/1/src/full-codegen.cc#newcode747 src/full-codegen.cc:747: DoTest(expr, &discard, &restore, &restore); On 2011/06/10 09:35:06, Kevin Millikin wrote:
On 2011/06/10 09:18:18, fschneider wrote: > Shouldn't the test of the left subexpressions get the test ID
left->test_id()?
> It has to match what the Crankshaft graph builder is doing.
I think you could do it either way (as long as they agree), but
Florian's
suggestions seems more straightforward. Use the ID of the expression
we're
testing.
Done. http://codereview.chromium.org/7046073/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
