LGTM with comments addressed Sorry for the delay - it somehow fell between the cracks.
http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode666 src/arm/macro-assembler-arm.cc:666: MemOperand src2(src); Please move the declaration of src2 closer to where it is used. I suggest declaring it twice just before each src2.set_offset(...), as there is one if branch where it is not used. http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode676 src/arm/macro-assembler-arm.cc:676: } else { // PostIndex or NegPostIndex. Please assert PostIndex or NegPostIndex. http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode711 src/arm/macro-assembler-arm.cc:711: } else { // PostIndex or NegPostIndex. Please assert PostIndex or NegPostIndex. http://codereview.chromium.org/7080052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
