[v8-dev] Re: ARM: Add PostIndex support to Ldrd/Strd macro fallback code.... (issue7080052)

[m . m . capewell]

http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode666
src/arm/macro-assembler-arm.cc:666: MemOperand src2(src);
On 2011/06/14 10:44:01, Søren Gjesse wrote:

Please move the declaration of src2 closer to where it is used. I

suggest

declaring it twice just before each src2.set_offset(...), as there is

one if

branch where it is not used.

Done.

http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode676
src/arm/macro-assembler-arm.cc:676: } else {  // PostIndex or
NegPostIndex.
On 2011/06/14 10:44:01, Søren Gjesse wrote:

Please assert PostIndex or NegPostIndex.

Done.

http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode711
src/arm/macro-assembler-arm.cc:711: } else {  // PostIndex or
NegPostIndex.
On 2011/06/14 10:44:01, Søren Gjesse wrote:

Please assert PostIndex or NegPostIndex.

Done.

http://codereview.chromium.org/7080052/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev