LGTM, with comments
I think you should trim down the list. We try to only put stuff in the
change
log which is of interest to embedders to give them an idea of whether it
makes
sense for them to update.
http://codereview.chromium.org/7171015/diff/1/ChangeLog
File ChangeLog (right):
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode6
ChangeLog:6: performance of the latter construct.
Maybe change this to "Improve performance of try/catch" (leave out
internal details).
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode11
ChangeLog:11: Makefiles for all architectures on Linux.
Maybe shorten this to just "Added support for building Xcode project
files from GYP files"
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode16
ChangeLog:16: Implemented core support for FixedDoubleArrays.
Remove this - only internal.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode18
ChangeLog:18: Fixed a bug where an array load was incorrectly hoisted by
GVN.
I assume there is no issue for this.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode24
ChangeLog:24: to 63.
I assume there is no issue for this.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode26
ChangeLog:26: Removed the --debug-info flag and behave like its value is
true.
Please remove this.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode34
ChangeLog:34: Skip test-debug/DebuggerAgent on ARM. (issue 945)
Also remove this.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode40
ChangeLog:40: code.
Also remove this.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode42
ChangeLog:42: Do not redefine properties unneccesarily in seal and
freeze. (issue 1447)
Long line.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode45
ChangeLog:45: expects one now.
Also remove this.
http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode50
ChangeLog:50: Small valgrind fix.
Also remove this.
http://codereview.chromium.org/7171015/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
