LGTM
http://codereview.chromium.org/7171015/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode26 ChangeLog:26: Removed the --debug-info flag and behave like its value is true. On 2011/06/15 09:37:01, Sven wrote:
On 2011/06/15 09:19:45, Søren Gjesse wrote: > Please remove this.
Why? Isn't this an externally visible change?
It is, but I don't think it is relevant (I did not try, but running with --nodebug-info would most likely break stuff). http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode45 ChangeLog:45: expects one now. On 2011/06/15 09:37:01, Sven wrote:
On 2011/06/15 09:19:45, Søren Gjesse wrote: > Also remove this.
I think this has to be in the ChangeLog, because it is an API change
in v8.h,
too.
Oh, sorry. Then I think the line should say that the API IsExecutionTerminating() now might need an isolate http://codereview.chromium.org/7171015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
