[v8-dev] Re: Change timeType and dateType in i18n date format API into timeStyle and dateStyle to match the pr... (issue7244008)

[cira]

Fixed regex in number format section to have ^()$.


http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18n.js
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18n.js#newcode165
src/extensions/experimental/i18n.js:165: if
(!/^short|medium|long|full$/.test(dt)) ds = 'short';
On 2011/06/23 18:24:16, rginda wrote:

You'll need to parenthesize that regexp...
   /^(short|medium|long|full)$/

Done.

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18n.js#newcode178
src/extensions/experimental/i18n.js:178: if
(!/^short|medium|long|full$/.test(tt)) ts = 'short';
On 2011/06/23 18:24:16, rginda wrote:

Here too.

Done.

http://codereview.chromium.org/7244008/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev