LGTM
http://codereview.chromium.org/7244008/diff/4002/src/extensions/experimental/i18n.js File src/extensions/experimental/i18n.js (right): http://codereview.chromium.org/7244008/diff/4002/src/extensions/experimental/i18n.js#newcode184 src/extensions/experimental/i18n.js:184: cleanSettings['timeStyle'] = tt; given that this will go away later, I wouldn't say you have to refactor what's inside if-block and else-if-block :-) If you like, you can. http://codereview.chromium.org/7244008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
