LGMT
http://codereview.chromium.org/7281006/diff/1001/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7281006/diff/1001/src/spaces.cc#newcode1226 src/spaces.cc:1226: Address old_start = space_end - capacity_; please add a comment about new space growing backwards from the end of the reserved space. http://codereview.chromium.org/7281006/diff/1001/src/spaces.cc#newcode1229 src/spaces.cc:1229: if (!heap()->isolate()->memory_allocator()->UncommitBlock(old_start, delta)) { I am a bit concerned about uncommiting piece of the page. It seems possible. http://codereview.chromium.org/7281006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
