http://codereview.chromium.org/7281006/diff/1001/src/spaces.cc File src/spaces.cc (right):
http://codereview.chromium.org/7281006/diff/1001/src/spaces.cc#newcode1226 src/spaces.cc:1226: Address old_start = space_end - capacity_; On 2011/06/29 11:16:59, Vyacheslav Egorov wrote:
please add a comment about new space growing backwards from the end of
the
reserved space.
Done. http://codereview.chromium.org/7281006/diff/1001/src/spaces.cc#newcode1229 src/spaces.cc:1229: if (!heap()->isolate()->memory_allocator()->UncommitBlock(old_start, delta)) { And you are correct to be worried. It won't happen that we free part of a page that contains content, but that's due to the interaction of minimum_capacity and the times-2 multiplier in Shrink, so instead of trying to codify that, we sohuld just round up before calling ShrinkTo. I'll change my other CL to do that instead of removing the assertion. http://codereview.chromium.org/7281006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
