Revision: 8616
Author: [email protected]
Date: Tue Jul 12 01:03:19 2011
Log: Fixed a long-standing TODO: Removed a few *-incl.h #includes from
isolate.h.
ZoneAllocationPolicy::New is not inlined anymore because this pulls in far
too
much stuff and doesn't really make any measurable performance difference.
And
no, the #includes are still not in alphabetical order... ;-)
Review URL: http://codereview.chromium.org/7346006
http://code.google.com/p/v8/source/detail?r=8616
Modified:
/branches/bleeding_edge/src/debug.h
/branches/bleeding_edge/src/frames.cc
/branches/bleeding_edge/src/isolate.h
/branches/bleeding_edge/src/scopeinfo.cc
/branches/bleeding_edge/src/scopes.cc
/branches/bleeding_edge/src/string-stream.cc
/branches/bleeding_edge/src/type-info.h
/branches/bleeding_edge/src/zone.h
=======================================
--- /branches/bleeding_edge/src/debug.h Fri Jun 10 02:54:04 2011
+++ /branches/bleeding_edge/src/debug.h Tue Jul 12 01:03:19 2011
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -35,6 +35,7 @@
#include "execution.h"
#include "factory.h"
#include "flags.h"
+#include "frames-inl.h"
#include "hashmap.h"
#include "platform.h"
#include "string-stream.h"
=======================================
--- /branches/bleeding_edge/src/frames.cc Wed Jun 29 06:02:00 2011
+++ /branches/bleeding_edge/src/frames.cc Tue Jul 12 01:03:19 2011
@@ -36,6 +36,8 @@
#include "scopeinfo.h"
#include "string-stream.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
=======================================
--- /branches/bleeding_edge/src/isolate.h Tue Jul 5 08:49:39 2011
+++ /branches/bleeding_edge/src/isolate.h Tue Jul 12 01:03:19 2011
@@ -1356,10 +1356,4 @@
} } // namespace v8::internal
-// TODO(isolates): Get rid of these -inl.h includes and place them only
where
-// they're needed.
-#include "allocation-inl.h"
-#include "zone-inl.h"
-#include "frames-inl.h"
-
#endif // V8_ISOLATE_H_
=======================================
--- /branches/bleeding_edge/src/scopeinfo.cc Wed May 11 04:26:11 2011
+++ /branches/bleeding_edge/src/scopeinfo.cc Tue Jul 12 01:03:19 2011
@@ -32,6 +32,8 @@
#include "scopeinfo.h"
#include "scopes.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
=======================================
--- /branches/bleeding_edge/src/scopes.cc Mon Jul 4 02:34:47 2011
+++ /branches/bleeding_edge/src/scopes.cc Tue Jul 12 01:03:19 2011
@@ -34,6 +34,8 @@
#include "prettyprinter.h"
#include "scopeinfo.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
=======================================
--- /branches/bleeding_edge/src/string-stream.cc Fri Mar 18 13:35:07 2011
+++ /branches/bleeding_edge/src/string-stream.cc Tue Jul 12 01:03:19 2011
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -30,6 +30,8 @@
#include "factory.h"
#include "string-stream.h"
+#include "allocation-inl.h"
+
namespace v8 {
namespace internal {
=======================================
--- /branches/bleeding_edge/src/type-info.h Mon Jun 20 05:33:08 2011
+++ /branches/bleeding_edge/src/type-info.h Tue Jul 12 01:03:19 2011
@@ -30,7 +30,6 @@
#include "allocation.h"
#include "globals.h"
-#include "zone.h"
#include "zone-inl.h"
namespace v8 {
=======================================
--- /branches/bleeding_edge/src/zone.h Mon May 23 15:23:50 2011
+++ /branches/bleeding_edge/src/zone.h Tue Jul 12 01:03:19 2011
@@ -164,7 +164,7 @@
class ZoneListAllocationPolicy {
public:
// Allocate 'size' bytes of memory in the zone.
- INLINE(static void* New(int size));
+ static void* New(int size);
// De-allocation attempts are silently ignored.
static void Delete(void* p) { }
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
