Revision: 8645
Author: [email protected]
Date: Wed Jul 13 07:43:09 2011
Log: Fix shortcutting bug in HInferRepresentation
* src/hydrogen.cc (HInferRepresentation::Analyze): Fix iterative loop
over phis; the shortcutting behavior of || appears to be accidental
here, causing O(n^2) convergence. Not that it matters much, but hey!
While I'm at it, a minor comment fix:
* src/hydrogen-instructions.h (EnsureAndPropagateNotMinusZero): Fix a
comment about the kinds of instructions that propagate to multiple
inputs.
BUG=
TEST=passes tools/test.py
Review URL: http://codereview.chromium.org/7350019
Patch from Andy Wingo <[email protected]>.
http://code.google.com/p/v8/source/detail?r=8645
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.h
/branches/bleeding_edge/src/hydrogen.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Thu Jul 7 05:01:49
2011
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Wed Jul 13 07:43:09
2011
@@ -588,9 +588,9 @@
// it would otherwise output what should be a minus zero as an int32
zero.
// If the operation also exists in a form that takes int32 and outputs
int32
// then the operation should return its input value so that we can
propagate
- // back. There are two operations that need to propagate back to more
than
- // one input. They are phi and binary add. They always return NULL and
- // expect the caller to take care of things.
+ // back. There are three operations that need to propagate back to more
than
+ // one input. They are phi and binary div and mul. They always return
NULL
+ // and expect the caller to take care of things.
virtual HValue* EnsureAndPropagateNotMinusZero(BitVector* visited) {
visited->Add(id());
return NULL;
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Tue Jul 5 06:21:29 2011
+++ /branches/bleeding_edge/src/hydrogen.cc Wed Jul 13 07:43:09 2011
@@ -1666,8 +1666,8 @@
HValue* use = it.value();
if (use->IsPhi()) {
int id = HPhi::cast(use)->phi_id();
- change = change ||
- connected_phis[i]->UnionIsChanged(*connected_phis[id]);
+ if (connected_phis[i]->UnionIsChanged(*connected_phis[id]))
+ change = true;
}
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
