Reviewers: Søren Gjesse,
Message:
Simplified the sample shell so that it is actually just a sample program.
Therefore it becomes no longer suitable to be a test platform for unit
tests.
The priority on this is low since I'm not going to land this before the
switch
to d8 is complete.
Sorry to send all the code reviews to you, Soren. Maybe you can recommend me
somebody in case I need a reviewer for this part of code when you are on
vacation :)
http://codereview.chromium.org/7354022/diff/1/samples/shell.cc
File samples/shell.cc (left):
http://codereview.chromium.org/7354022/diff/1/samples/shell.cc#oldcode52
samples/shell.cc:52: static void ExitShell(int exit_code) {
Removed since there is no longer multi-threading.
http://codereview.chromium.org/7354022/diff/1/samples/shell.cc#oldcode71
samples/shell.cc:71: v8::Handle<v8::Value> Int8Array(const
v8::Arguments& args);
Removed external arrays completely.
http://codereview.chromium.org/7354022/diff/1/samples/shell.cc#oldcode85
samples/shell.cc:85:
Removed support for --isolate.
http://codereview.chromium.org/7354022/diff/1/samples/shell.cc#oldcode215
samples/shell.cc:215:
Removed support for compression.
http://codereview.chromium.org/7354022/diff/1/samples/shell.cc#oldcode341
samples/shell.cc:341:
Removed stress runs.
Description:
Simplified the sample shell, making it unsuitable for tests.
Please review this at http://codereview.chromium.org/7354022/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M samples/shell.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
