LGTM with comments addressed.
http://codereview.chromium.org/7377008/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): http://codereview.chromium.org/7377008/diff/1/src/platform-linux.cc#newcode86 src/platform-linux.cc:86: if (sizeof(void*) == 8 && (isolate = Isolate::UncheckedCurrent())) { I would prefer conditional compilation based on V8_TARGET_ARCH_X64 here instead of sizeof(void*) comparison. Also we prefer explicit comparisons with NULL to implicit to boolean conversion: Isolate* isolate = Isolate::UncheckedCurrent(); if (isolate != NULL) ... http://codereview.chromium.org/7377008/diff/1/src/platform-linux.cc#newcode109 src/platform-linux.cc:109: uint64_t seed = Ticks() | (getpid() << 16); I think the comment above needs updating. http://codereview.chromium.org/7377008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
