More comments.

http://codereview.chromium.org/7377008/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

http://codereview.chromium.org/7377008/diff/1/src/platform-linux.cc#newcode89
src/platform-linux.cc:89: uint64_t raw_addr =
(static_cast<uint64_t>(rnd1) << 33) |
I think it should be 34 not 33.

http://codereview.chromium.org/7377008/diff/1/src/platform-linux.cc#newcode93
src/platform-linux.cc:93: raw_addr <<= 18;
Look into globals.h. There are macroses that allow to define 64bit
constants.

http://codereview.chromium.org/7377008/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to