LGTM This is two changes mixed together. Could you upload just the 'in' patch?
http://codereview.chromium.org/7390028/diff/1/src/factory.h File src/factory.h (right): http://codereview.chromium.org/7390028/diff/1/src/factory.h#newcode257 src/factory.h:257: void BecomeJSObject(Handle<JSProxy> object); This is from a previous change? http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h#newcode4166 src/objects-inl.h:4166: Add an extra newline. We usually have two newlines between methods. http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js File test/mjsunit/harmony/proxies.js (right): http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js#newcode407 test/mjsunit/harmony/proxies.js:407: // Element (in). We should have tests for the case where the Has trap throws an exception. http://codereview.chromium.org/7390028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
