New upload is diff to master only. Sorry for the mess.
http://codereview.chromium.org/7390028/diff/1/src/factory.h File src/factory.h (right): http://codereview.chromium.org/7390028/diff/1/src/factory.h#newcode257 src/factory.h:257: void BecomeJSObject(Handle<JSProxy> object); On 2011/07/19 08:18:05, Mads Ager wrote:
This is from a previous change?
Yes, sorry, I keep messing up with Git branches... http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7390028/diff/1/src/objects-inl.h#newcode4166 src/objects-inl.h:4166: On 2011/07/19 08:18:05, Mads Ager wrote:
Add an extra newline. We usually have two newlines between methods.
Done. http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js File test/mjsunit/harmony/proxies.js (right): http://codereview.chromium.org/7390028/diff/1/test/mjsunit/harmony/proxies.js#newcode407 test/mjsunit/harmony/proxies.js:407: // Element (in). On 2011/07/19 08:18:05, Mads Ager wrote:
We should have tests for the case where the Has trap throws an
exception. I left that for the TODO at the top, since I still have to add exception cases to most of the other tests, too. http://codereview.chromium.org/7390028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
