http://codereview.chromium.org/7529007/diff/4001/src/bootstrapper.cc File src/bootstrapper.cc (right):
http://codereview.chromium.org/7529007/diff/4001/src/bootstrapper.cc#newcode2180 src/bootstrapper.cc:2180: if (FLAG_harmony_weakmaps) { // -- W e a k M a p Can you perhaps move this into a separate function InitializeExperimentalGlobal? http://codereview.chromium.org/7529007/diff/4001/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/7529007/diff/4001/src/flag-definitions.h#newcode101 src/flag-definitions.h:101: DEFINE_bool(harmony_weakmaps, false, "enable harmony weak-maps") Nit: use space instead of hyphen. http://codereview.chromium.org/7529007/diff/4001/src/messages.js File src/messages.js (right): http://codereview.chromium.org/7529007/diff/4001/src/messages.js#newcode204 src/messages.js:204: invalid_weakmap_key: ["Invalid value used as weak-map key"], Nit: space instead of hyphen. http://codereview.chromium.org/7529007/diff/4001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7529007/diff/4001/src/runtime.cc#newcode638 src/runtime.cc:638: RUNTIME_FUNCTION(MaybeObject*, Runtime_WeakMapCreate) { Since unlike the others, this function does not actually create the object, but only initializes it, I would prefer calling it WeakMapInitialize or WeakMapConstruct. http://codereview.chromium.org/7529007/diff/4001/src/weakmap.js File src/weakmap.js (right): http://codereview.chromium.org/7529007/diff/4001/src/weakmap.js#newcode43 src/weakmap.js:43: if (!IS_OBJECT(key)) { You probably want IS_SPEC_OBJECT here (and below). http://codereview.chromium.org/7529007/diff/4001/src/weakmap.js#newcode61 src/weakmap.js:61: //%SetProperty($WeakMap.prototype, "constructor", $WeakMap, DONT_ENUM); Is there a reason that this is commented out? http://codereview.chromium.org/7529007/diff/4001/test/mjsunit/harmony/weakmaps.js File test/mjsunit/harmony/weakmaps.js (right): http://codereview.chromium.org/7529007/diff/4001/test/mjsunit/harmony/weakmaps.js#newcode55 test/mjsunit/harmony/weakmaps.js:55: TestMapping(m, new Object, new Object); Does this work with proxies as keys? http://codereview.chromium.org/7529007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
