http://codereview.chromium.org/7529007/diff/4001/src/bootstrapper.cc File src/bootstrapper.cc (right):
http://codereview.chromium.org/7529007/diff/4001/src/bootstrapper.cc#newcode2185 src/bootstrapper.cc:2185: //global_context()->set_weakmap_function(*weakmap_fun); Should this really be commented out? If the code isn't used, it's better to remove it. http://codereview.chromium.org/7529007/diff/4001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7529007/diff/4001/src/objects.h#newcode6648 src/objects.h:6648: DISALLOW_IMPLICIT_CONSTRUCTORS(JSWeakMap); I wonder, do you really properly handle in-line properties here? Or do you accidentally overwrite them? http://codereview.chromium.org/7529007/diff/4001/test/mjsunit/harmony/weakmaps.js File test/mjsunit/harmony/weakmaps.js (right): http://codereview.chromium.org/7529007/diff/4001/test/mjsunit/harmony/weakmaps.js#newcode96 test/mjsunit/harmony/weakmaps.js:96: assertTrue(WeakMap.prototype.get instanceof Function) add test cases that set and get arbitrary properties and elements on a weak map, especially ones designed to trigger fast in-object properties. http://codereview.chromium.org/7529007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
