LGTM Might be a good idea to add verification for sliced strings.
http://codereview.chromium.org/7477045/diff/20075/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7477045/diff/20075/src/arm/code-stubs-arm.cc#newcode5431 src/arm/code-stubs-arm.cc:5431: __ nop(0); // Jumping as first instruction would crash the code generation. nit: shouldn't nop go under if as well? http://codereview.chromium.org/7477045/diff/20075/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7477045/diff/20075/src/arm/lithium-codegen-arm.cc#newcode3484 src/arm/lithium-codegen-arm.cc:3484: Operand(SeqTwoByteString::kHeaderSize - kHeapObjectTag nit: apparently v8 style is not to start continuation line with operators. http://codereview.chromium.org/7477045/diff/20075/src/heap.h File src/heap.h (right): http://codereview.chromium.org/7477045/diff/20075/src/heap.h#newcode95 src/heap.h:95: V(Map, sliced_symbol_map, SlicedSymbolMap) \ do we need these symbol maps? http://codereview.chromium.org/7477045/diff/20075/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7477045/diff/20075/src/objects-inl.h#newcode295 src/objects-inl.h:295: || ((type_ & kStringRepresentationMask) == kSlicedStringTag))); Isn't it similar to change to Heap::TargetSpaceId? http://codereview.chromium.org/7477045/diff/20075/test/cctest/test-strings.cc File test/cctest/test-strings.cc (right): http://codereview.chromium.org/7477045/diff/20075/test/cctest/test-strings.cc#newcode522 test/cctest/test-strings.cc:522: result = v8::Script::Compile(v8::String::New(check))->Run(); I think we have something like CompileAndRun http://codereview.chromium.org/7477045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
