I did some corrections and replaced the CharCodeAt stuff with simpler code on
all three platforms. As it turned out, special handling for constant indexes
doesn't really result in any better performance.


http://codereview.chromium.org/7477045/diff/39001/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7477045/diff/39001/src/heap.cc#newcode2648
src/heap.cc:2648: !ConsString::cast(buffer)->first()->IsSeqString())) ||
A little ugly for now, but this will be removed once I dealt with the
externalized string issue. For now externalized strings won't be sliced,
but copied.

http://codereview.chromium.org/7477045/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to