Reviewers: jkummerow, Message: PTAL.
http://codereview.chromium.org/7586001/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/7586001/diff/1/include/v8.h#newcode3609 include/v8.h:3609: static bool IsActive(); Moving the implementation to v8threads.cc seems to make Visual Studio linker stop complaining when building with shared library. I don't know why exactly. http://codereview.chromium.org/7586001/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode804 src/d8.cc:804: } Mostly copied from v8::internal::OS::FOpen, but for the sake of being able to build it with shared lib, a little bit duplicate code. http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode999 src/d8.cc:999: Handle<String> result = String::New(chars, size); Saved duplicate code. http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode1161 src/d8.cc:1161: delete[] files; Memory leak. Description: Fixed a known issue in D8 (read file), enabled D8 shared library build on Windows. Please review this at http://codereview.chromium.org/7586001/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M include/v8.h M src/d8.h M src/d8.cc M src/v8threads.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
