LGTM. Please make sure you test this on all platforms with both shared and static library builds.
http://codereview.chromium.org/7586001/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode29 src/d8.cc:29: #if (defined(USING_V8_SHARED) || defined(BUILDING_V8_SHARED)) I guess you could avoid all the renaming and still get a catch-all solution if you just did this: #if (defined(BUILDING_V8_SHARED) || defined(V8_SHARED)) #define USING_V8_SHARED #endif I'm not sure if that would be better. If you've tested the current approach and it works on all OSs, fine by me. http://codereview.chromium.org/7586001/diff/1/src/d8.cc#newcode63 src/d8.cc:63: #ifndef ASSERT you sure about this? http://codereview.chromium.org/7586001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
