LGTM
http://codereview.chromium.org/7617005/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/7617005/diff/1/test/cctest/test-api.cc#newcode402 test/cctest/test-api.cc:402: if (HEAP->incremental_marking()->IsMarking()) { Maybe we should always abort incremental marking when we call CollectAllAvailableGarbage. It has this 'All' in the name after all. We also have a kMakeHeapIterableMask GC flag that cancels incremental marking internally. I think we can have another flag that cancels marking but does not do precise sweeping. http://codereview.chromium.org/7617005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
