http://codereview.chromium.org/7617005/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right):
http://codereview.chromium.org/7617005/diff/1/test/cctest/test-api.cc#newcode402 test/cctest/test-api.cc:402: if (HEAP->incremental_marking()->IsMarking()) { Actaully CollectAllAvailableGarbage does use the kMakeHeapIterableMask flag, so this call is safe. On the other hand CollectAllGarbage doesn't do it (and it has "All" in the name too (which is odd naming - the unqualified CollectAllGarbage collects less than the qualified CollectAllAvailableGarbage, and "Available" seems odd to use about garbage which, by definition, isn't reachable)). I've changed the code to use CollectAllAvailableGarbage instead of CollectAllGarbage instead of inserting these manual aborts. http://codereview.chromium.org/7617005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
