LGTM
http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode3051 src/runtime.cc:3051: AssertNoAllocation no_heap_allocation; // ensure vectors stay valid Do we still need this? http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode3162 src/runtime.cc:3162: AssertNoAllocation no_heap_allocation; // ensure vectors stay valid do we still need this? http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode3402 src/runtime.cc:3402: AssertNoAllocation no_gc; Do we still need this? http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode5975 src/runtime.cc:5975: AssertNoAllocation nogc; why the rename? http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode8832 src/runtime.cc:8832: AssertNoAllocation no_allocation; Do we still need this? http://codereview.chromium.org/7710018/diff/4001/test/mjsunit/string-split.js File test/mjsunit/string-split.js (left): http://codereview.chromium.org/7710018/diff/4001/test/mjsunit/string-split.js#oldcode120 test/mjsunit/string-split.js:120: var all_ascii_chars = []; Why are these not valid anymore? http://codereview.chromium.org/7710018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
