http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode3051 src/runtime.cc:3051: AssertNoAllocation no_heap_allocation; // ensure vectors stay valid It's an assert, so we don't *need* it, but if it's possible to add it, it's great. Ditto for the other cases. http://codereview.chromium.org/7710018/diff/4001/src/runtime.cc#newcode5975 src/runtime.cc:5975: AssertNoAllocation nogc; I reverted part of the previous patch, which contained a rename in the other direction (which seemed more consistent). I'll rename it again. http://codereview.chromium.org/7710018/diff/4001/test/mjsunit/string-split.js File test/mjsunit/string-split.js (left): http://codereview.chromium.org/7710018/diff/4001/test/mjsunit/string-split.js#oldcode120 test/mjsunit/string-split.js:120: var all_ascii_chars = []; Also lost in revert. Will re-add. http://codereview.chromium.org/7710018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
