The env file doesn't seem to work. I compiled the first time with
console=readline. The second time without, but nothing is recompiled. The
third
attempt with library=shared, but nothing recompiled either.
+ comments below.
http://codereview.chromium.org/7748018/diff/1/Makefile
File Makefile (right):
http://codereview.chromium.org/7748018/diff/1/Makefile#newcode101
Makefile:101: $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES))
trailing whitespace.
http://codereview.chromium.org/7748018/diff/1/Makefile#newcode112
Makefile:112: else mv $(ENVFILE).new $(ENVFILE); fi
/bin/sh: out/environment.new: No such file or directory
mv: cannot stat `out/environment.new': No such file or directory
make: *** [generate_environment_file] Error 1
Take care of the case where OUTDIR doesnt exist. A simple mkdir -p
before checking env file would suffice.
http://codereview.chromium.org/7748018/diff/1/build/common.gypi
File build/common.gypi (right):
http://codereview.chromium.org/7748018/diff/1/build/common.gypi#newcode63
build/common.gypi:63: 'v8_enable_gdbjit%': 0,
Maybe add some comments like those options above. Or not if you think
its unnecessary.
http://codereview.chromium.org/7748018/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
