Thanks for the thorough testing! Please take another look. I think everything works now :-)
http://codereview.chromium.org/7748018/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/7748018/diff/1/Makefile#newcode101 Makefile:101: $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES)) On 2011/08/26 07:26:42, Yang wrote:
trailing whitespace.
Done. http://codereview.chromium.org/7748018/diff/1/Makefile#newcode112 Makefile:112: else mv $(ENVFILE).new $(ENVFILE); fi On 2011/08/26 07:26:42, Yang wrote:
/bin/sh: out/environment.new: No such file or directory mv: cannot stat `out/environment.new': No such file or directory make: *** [generate_environment_file] Error 1
Take care of the case where OUTDIR doesnt exist. A simple mkdir -p
before
checking env file would suffice.
Done. http://codereview.chromium.org/7748018/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7748018/diff/1/build/common.gypi#newcode63 build/common.gypi:63: 'v8_enable_gdbjit%': 0, On 2011/08/26 07:26:42, Yang wrote:
Maybe add some comments like those options above. Or not if you think
its
unnecessary.
This option's description in the SConstruct file is "Enable GDB JIT interface" -- I don't think that gives much additional information ;-) Similar for the other two uncommented options. Their names are just as verbose as a comment would be. http://codereview.chromium.org/7748018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
