LGTM for the one-word patch itself, but the surrounding code has to be
clarified
(see my comment).
http://codereview.chromium.org/7741041/diff/1/src/x64/regexp-macro-assembler-x64.cc
File src/x64/regexp-macro-assembler-x64.cc (right):
http://codereview.chromium.org/7741041/diff/1/src/x64/regexp-macro-assembler-x64.cc#newcode1188
src/x64/regexp-macro-assembler-x64.cc:1188: intptr_t delta =
*code_handle - re_code;
This change looks OK, but...
http://codereview.chromium.org/7741041/diff/1/src/x64/regexp-macro-assembler-x64.cc#newcode1190
src/x64/regexp-macro-assembler-x64.cc:1190: *return_address += delta;
This (old) code looks wrong: The delta is in units of Code, but we add
it onto a byte pointer. Is this really correct? I suspect that we should
cast the Code pointers to byte pointers before doing the subtraction. If
I am wrong, a comment why the code is correct should be added.
http://codereview.chromium.org/7741041/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
