Isn't the issue that, as far as I can see, this part of code is only called when the we switch to the profiler thread in the middle of regexp code and in there trigger GC? If crankshaft is disabled, profiler doesn't run and the regexp code won't be interrupted and we won't jump into this part of code in the first place.
-- Yang On Fri, Aug 26, 2011 at 5:43 PM, <[email protected]> wrote: > LGTM. > You shouldn't need crankshaft, just a compacting GC that moves the calling > Code > object. I'm not sure there is a good way to do that consistently, though. > > > http://codereview.chromium.**org/7741041/<http://codereview.chromium.org/7741041/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
