LGTM
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5707 src/ia32/code-stubs-ia32.cc:5707: __ SmiTag(edx); // Make edx a smi again. do you want to fallback here from make_two_character_string? http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5728 src/ia32/code-stubs-ia32.cc:5728: const uint32_t kSlicedNotConsMask = kSlicedStringTag & ~kConsStringTag; lift those constants into objects.h? http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5747 src/ia32/code-stubs-ia32.cc:5747: __ mov(edi, eax); maybe keep the parent string in eax and save this move? http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5769 src/ia32/code-stubs-ia32.cc:5769: __ SmiTag(ecx); apparently there is too much of tagging/untagging, but it should have only minimal perf impact. http://codereview.chromium.org/7744052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
