LGTM
http://codereview.chromium.org/7744052/diff/9001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7744052/diff/9001/src/ia32/code-stubs-ia32.cc#newcode5756 src/ia32/code-stubs-ia32.cc:5756: // Allocate new sliced string. At this point we do not reload the instance This is clever, but the comment is a bit confusing. I'd replace "parent" with "original" to match the comment about ebx. Also later it may help to use "newly created slice" to avoid confusion with the one we might have just unwrapped. http://codereview.chromium.org/7744052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
