LGTM.
http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-crankshaft.js File test/mjsunit/harmony/block-let-crankshaft.js (right): http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-crankshaft.js#newcode55 test/mjsunit/harmony/block-let-crankshaft.js:55: } catch (e) { Use assertThrows to test if there actually was an exception thrown. http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-crankshaft.js#newcode60 test/mjsunit/harmony/block-let-crankshaft.js:60: g(42, true); Also assertThrows here. http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-semantics.js File test/mjsunit/harmony/block-let-semantics.js (right): http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-semantics.js#newcode36 test/mjsunit/harmony/block-let-semantics.js:36: } catch (e) { Use AssertThrows? http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-semantics.js#newcode45 test/mjsunit/harmony/block-let-semantics.js:45: eval("(function(){ {" + s + ";} })")(); AssertThrows here too. http://codereview.chromium.org/7671042/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
