Revision: 9081
Author: [email protected]
Date: Wed Aug 31 06:01:28 2011
Log: Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py
Review URL: http://codereview.chromium.org/7785025
http://code.google.com/p/v8/source/detail?r=9081
Modified:
/branches/bleeding_edge/Makefile
/branches/bleeding_edge/tools/test-wrapper-gypbuild.py
=======================================
--- /branches/bleeding_edge/Makefile Fri Aug 26 04:23:51 2011
+++ /branches/bleeding_edge/Makefile Wed Aug 31 06:01:28 2011
@@ -98,8 +98,9 @@
# File where previously used GYPFLAGS are stored.
ENVFILE = $(OUTDIR)/environment
-.PHONY: all clean $(ENVFILE).new \
- $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES))
+.PHONY: all check clean $(ENVFILE).new \
+ $(ARCHES) $(MODES) $(BUILDS) $(CHECKS)
$(addsuffix .clean,$(ARCHES)) \
+ $(addsuffix .check,$(MODES)) $(addsuffix .check,$(ARCHES))
# Target definitions. "all" is the default.
all: $(MODES)
=======================================
--- /branches/bleeding_edge/tools/test-wrapper-gypbuild.py Thu Aug 25
07:50:09 2011
+++ /branches/bleeding_edge/tools/test-wrapper-gypbuild.py Wed Aug 31
06:01:28 2011
@@ -53,6 +53,9 @@
result.add_option("--outdir",
help='Base output directory',
default='out')
+ result.add_option("--no-presubmit",
+ help='Skip presubmit checks',
+ default=False, action="store_true")
# Flags this wrapper script handles itself:
result.add_option("-m", "--mode",
@@ -202,6 +205,11 @@
return 1
workspace = abspath(join(dirname(sys.argv[0]), '..'))
+
+ if not options.no_presubmit:
+ print ">>> running presubmit tests"
+ subprocess.call([workspace + '/tools/presubmit.py'])
+
args_for_children = [workspace + '/tools/test.py'] +
PassOnOptions(options)
args_for_children += ['--no-build', '--build-system=gyp']
for arg in args:
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
