LGTM, but Erik and William might be better reviewers for ARM and x64.
http://codereview.chromium.org/7795018/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7795018/diff/1/src/arm/code-stubs-arm.cc#newcode5658 src/arm/code-stubs-arm.cc:5658: STATIC_ASSERT(kIsIndirectStringMask == (kSlicedStringTag & kConsStringTag)); those constants might be worth lifting into objects.h http://codereview.chromium.org/7795018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
