LGTM.
http://codereview.chromium.org/7795018/diff/3002/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7795018/diff/3002/src/x64/code-stubs-x64.cc#newcode4763 src/x64/code-stubs-x64.cc:4763: __ testb(rbx, Immediate(kAsciiStringTag)); I would use kStringEncodingMask and assert kStringEncodingMask & kAsciiStringTag != 0 and kStringEncodingMask & kTwoByteStringTag == 0 http://codereview.chromium.org/7795018/diff/3002/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/7795018/diff/3002/src/x64/macro-assembler-x64.cc#newcode3662 src/x64/macro-assembler-x64.cc:3662: void MacroAssembler::AllocateSlicedString(Register result, I would call this "AllocateTwoByteSlicedString". Even though constants leave off "TwoByte" in their names, I think we use it in function names. http://codereview.chromium.org/7795018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
