Reviewers: Yang,

Message:
Yang: PTAL.

Peter: FYI.

Description:
move -m32 flag for ia32 targets from standalone.gypi to common.gypi

so that we no longer depend on Chromium setting this flag.

BUG=v8:1648


Please review this at http://codereview.chromium.org/7830004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M build/common.gypi
  M build/standalone.gypi


Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 834516ffd4b1a198d7de4528fa4182d25e7c8f72..9b32608178f0c744dd52c484506369ed33cc131c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -173,6 +173,14 @@
           },
         },
       }],
+      ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris"', {
+        'conditions': [
+          [ 'target_arch=="ia32"', {
+            'cflags': [ '-m32' ],
+            'ldflags': [ '-m32' ],
+          }],
+        ],
+      }],
     ],
     'configurations': {
       'Debug': {
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 81909f19a865818cb6b4c6a17232ecdec091cbe3..cb5e1330397b4cc3ffe134ad2e5df1dd134e8a29 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -79,10 +79,6 @@
                     '-fno-exceptions', '-pedantic' ],
         'ldflags': [ '-pthread', ],
         'conditions': [
-          [ 'target_arch=="ia32"', {
-            'cflags': [ '-m32' ],
-            'ldflags': [ '-m32' ],
-          }],
           [ 'OS=="linux"', {
             'cflags': [ '-ansi' ],
           }],


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to