LGTM.
http://codereview.chromium.org/7827009/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/7827009/diff/1/src/hydrogen-instructions.h#newcode688 src/hydrogen-instructions.h:688: #define DECLARE_DO(type) result |= (1 << kChanges##type); This wasn't introduced in your change, but could you should rename this macro (though I find the name funny whenever I see it). I once defined a macro called "DECLARE_DO", because it was declaring a bunch of functions named DoXXX. Then, somebody else copied it everywhere they could, and now we have DECLARE_DO for things that are declaring something other than "Do" or that are not even declaring anything at all. :) #define ADD_FLAG(flag) result |= (1 << kChanges##flag); GVN_FLAG_LIST(ADD_FLAG) #undef ADD_FLAG http://codereview.chromium.org/7827009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
